-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-add the V1 of client config version #1917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e723559 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Amplifiyer
added
the
run-e2e
Label that will include e2e tests in PR checks workflow
label
Aug 26, 2024
sobolk
previously approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0618
previously approved these changes
Aug 26, 2024
sobolk
previously approved these changes
Aug 26, 2024
sobolk
approved these changes
Aug 26, 2024
0618
approved these changes
Aug 26, 2024
johnpc
approved these changes
Aug 26, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
V1 was replaced with V1.1 in this PR #1742 that caused a breaking change for clients that were using
generateClientConfig
programmatically.Issue number, if available:
Changes
This PR adds V1 back. Renamed the 1.1 version as V1_1 in the code nomenclature (namespace and methods etc)
Note: there is a hard dependency that all fragments of the client config be on the same version, so if a customer is using a new backend-cli version (V1.1 of outputs) but trying to generate the outputs for V1, they have to ensure to pass the
version
in thebackend.addOutput()
call as the default there is always the latest one.Corresponding docs PR, if applicable:
Validation
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.