-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add option to for dependency validator to allow list dependencies that can violate consistency check #1920
feat: Add option to for dependency validator to allow list dependencies that can violate consistency check #1920
Conversation
…nown inconsistent dependencies
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good.
I left two suggestions.
And we should add at least one test or add to one of existing tests to cover this new aspect.
Co-authored-by: Kamil Sobol <[email protected]>
…nconsistent yield correct results
Problem
Issue number, if available:
#966
Changes
Corresponding docs PR, if applicable:
N/A
Validation
Added tests for instances where:
All tests successful
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.