-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add storage access rules to outputs #1927
Merged
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5cf3823
add storage access rules to outputs
rtpascual 1284ce1
fix tests
rtpascual 6ef5567
Merge branch 'main' into storage-access-outputs
rtpascual dfcfde5
Merge branch 'main' into storage-access-outputs
rtpascual 98662a8
remove read action from storage access rule outputs in favor of get a…
rtpascual 54da34d
Merge branch 'main' into storage-access-outputs
rtpascual dddd410
update api.md
rtpascual eedd44b
Merge branch 'main' into storage-access-outputs
rtpascual 3b77458
update permissions for non entity roles for entity_id paths
rtpascual 0e9497d
Merge branch 'main' into storage-access-outputs
rtpascual 3471c97
add entity id substitution constant
rtpascual c426a0d
add comments for new behavior with owner paths
rtpascual 12db2ca
add back read
rtpascual 69dbc7b
pr feedback
rtpascual 2b23793
update api.md
rtpascual File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
'@aws-amplify/client-config': minor | ||
'@aws-amplify/backend-output-schemas': patch | ||
'@aws-amplify/integration-tests': patch | ||
'@aws-amplify/backend-storage': patch | ||
'@aws-amplify/backend': patch | ||
'@aws-amplify/backend-cli': patch | ||
--- | ||
|
||
add storage access rules to outputs |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
export const entityIdPathToken = '{entity_id}'; | ||
export const entityIdSubstitution = '${cognito-identity.amazonaws.com:sub}'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't this be a breaking change for deployed apps ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, I forgot to think about impact on existing apps, adding this back in.