Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not bundle AWS SDK if default implementation is used. #1969

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Do not bundle AWS SDK if default implementation is used. #1969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9535f95
Do not bundle AWS SDK if default implementation is used.
sobolk Sep 6, 2024
8466e4a
Do not bundle AWS SDK if default implementation is used.
sobolk Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/happy-starfishes-trade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@aws-amplify/ai-constructs': patch
---

Do not bundle AWS SDK if default implementation is used
5 changes: 4 additions & 1 deletion packages/ai-constructs/src/conversation/conversation_handler_construct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,10 @@ export class ConversationHandlerFunction
entry: this.props.entry ?? defaultHandlerFilePath,
handler: 'handler',
bundling: {
bundleAwsSDK: true,
// Do not bundle SDK if conversation handler is using our default implementation which is
// compatible with Lambda provided SDK.
// For custom entry we do bundle SDK as we can't control version customer is coding against.
bundleAwsSDK: !!this.props.entry,
},
logGroup: new LogGroup(this, 'conversationHandlerFunctionLogGroup', {
retention: RetentionDays.INFINITE,
Expand Down
Loading