Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve type error regex #2022

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Improve type error regex #2022

merged 1 commit into from
Sep 18, 2024

Conversation

sobolk
Copy link
Member

@sobolk sobolk commented Sep 18, 2024

Problem

Errors in a form of

TypeError [ERR_INVALID_MODULE_SPECIFIER]: Invalid module ..../function/foo/resource.ts is not a valid package name imported from 
/Users/foo/Desktop/amplify-app/amplify/storage/foo/resource.ts
    at new NodeError (node:internal/errors:405:5)

I.e. with extra [ERR_INVALID_MODULE_SPECIFIER]
were not captured.

Changes

Adjust regex.

Validation

Test added.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sobolk sobolk requested a review from a team as a code owner September 18, 2024 18:07
Copy link

changeset-bot bot commented Sep 18, 2024

🦋 Changeset detected

Latest commit: da44648

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/backend-deployer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -122,7 +122,7 @@ export class CdkErrorMapper {
},
{
errorRegex: new RegExp(
`(SyntaxError|ReferenceError|TypeError):((?:.|${this.multiLineEolRegex})*?at .*)`
`(SyntaxError|ReferenceError|TypeError)( \\[[A-Z_]+])?:((?:.|${this.multiLineEolRegex})*?at .*)`
Copy link
Member Author

@sobolk sobolk Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you wonder why ] is not escaped. it doesn't have to be if there's no opening [.
image

@Amplifiyer Amplifiyer changed the title Handle CDK version mismatch Improve type error regex Sep 18, 2024
@sobolk sobolk merged commit 98673b0 into main Sep 18, 2024
38 checks passed
@sobolk sobolk deleted the another-type-error branch September 18, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants