Reference Auth #2118
Merged
Reference Auth #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
reviewed
Nov 6, 2024
packages/backend-auth/src/index.ts
Outdated
Comment on lines
2
to
3
| // ReferenceAuthConstruct is intentionally not public, but props are required | ||
| export { ReferenceAuthProps } from './reference_construct.js'; |
There was a problem hiding this comment.
Instead of this comment.
I'd move the type to reference_factory.ts.
To underscore that its primary purpose is to type the input to referenceAuth.
It can then be then used in construct as well.
If this happen to created import cycle then right place might be types.ts
There was a problem hiding this comment.
Updated, moved to reference_factory to make it more clear
Comment on lines
1
to
2
| // This executes within the custom resource lambda and errors get handled by the provider framework | ||
| /* eslint-disable amplify-backend-rules/prefer-amplify-errors */ |
There was a problem hiding this comment.
For Lambda runtime sources we'd rather create local .eslintrc.json in lambda directory and put suppression there.
See example here https://github.com/aws-amplify/amplify-backend/blob/main/packages/backend/src/engine/branch-linker/lambda/.eslintrc.json .
* chore: add working setup for e2e resources in ref auth * feed pr base sha and ref into envs before scripts (#2168) * feed pr base sha and ref into envs before scripts * removing empty file * chore: update names to use test prefix * chore: remove extra hyphen * chore: fix cleanup and add sandbox test * chore: make sure to throw if error describing stack is unknown --------- Co-authored-by: Roshane Pascual <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/integration-tests/src/test-projects/reference-auth/amplify/backend.ts
Fixed
Show fixed
Hide fixed
sobolk
previously approved these changes
Nov 8, 2024
sobolk
approved these changes
Nov 11, 2024
ShadowCat567
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Replaces PR (#2076)
Summary:
#1548
This adds support for referencing existing auth resources, while supporting the same behaviors that defineAuth allows.
You can use existing UserPool, IdentityPool, roles, and groups.
Data/Storage/Function resources do not require any changes or customization to work with reference auth.
Example fully featured backend, with groups, data, storage, and function handler.
Issue number, if available:
Changes
Corresponding docs PR, if applicable:
Validation
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.