bump graphql-generator dependency version for model-generator #2215
Conversation
atierian
added
the
run-e2e
🦋 Changeset detectedLatest commit: 8e33f10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/auth-construct/API.md
Outdated
| @@ -48,7 +47,7 @@ export type AuthProps = { | |||
| externalProviders?: ExternalProviderOptions; | |||
| }; | |||
| senders?: { | |||
| email: Pick<UserPoolSESOptions, 'fromEmail' | 'fromName' | 'replyTo'> | CustomEmailSender; | |||
| email: Pick<UserPoolSESOptions, 'fromEmail' | 'fromName' | 'replyTo'>; | |||
There was a problem hiding this comment.
The changes in API.md files should be in this PR.
Please either revert them or rebase PR with current main.
There was a problem hiding this comment.
The branch's parent is the current HEAD of main.
> git rev-parse HEAD~2
06e4def3eded2e4127c4501a4dce669abba900db
I'm assuming the API changes were necessary because running npm i to update the package-lock after bumping the graphql-generator version pulled in newer versions of other packages that aren't in main.
What do you suggest?
There was a problem hiding this comment.
That's not possible.
The changes in API.md files are related to code in the repo that was added recently.
npm run clean && npm install && npm run build && npm run update:api should help. (gonna push the change since I have it locally).
API.md files are generated from build artifacts. If local workspace is stale then it may give unexpected deltas.
There was a problem hiding this comment.
That makes a lot more sense. Thanks!
There was a problem hiding this comment.
If local workspace is stale then it may give unexpected deltas.
that is the reason we have check in PR build. we haven't found better way to enforce consistency.
Problem
model-generatordepends ongraphql-generatorwith a versioning rule of^0.4.0.graphql-generatorhas released0.5.0and0.5.1with updates thatmodel-generatorneeds to consume.Issue number, if available:
Changes
model-generators dependency ongraphql-generatorto^0.5.1.Note
I don't know why
graphql-generatoris still in0.I'll find out and, if appropriate, will bump it to
1.in a follow up so we don't have this issue anymore.Corresponding docs PR, if applicable:
Validation
Checklist
If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.If this PR requires a change to the Project Architecture README, I have included that update in this PR.If this PR requires a docs update, I have linked to that docs PR above.run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.