Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cleanup of generated env files to end of tests #2234

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

rtpascual
Copy link
Contributor

Problem

When running tests, generated env files for functions are left behind. This is only a problem locally (since test runners always run on clean environment) because writing tests that rely on existence/non-existence of these files may yield different results compared to test runners which will lead to confusion.

Issue number, if available:

Changes

Cleans up generated function env files at the end of tests that contain functions that generate them.

Corresponding docs PR, if applicable:

Validation

Made sure there are no generated function env files after running entire test suite. Unit tests should still pass.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rtpascual rtpascual requested a review from a team as a code owner November 15, 2024 00:50
Copy link

changeset-bot bot commented Nov 15, 2024

🦋 Changeset detected

Latest commit: 5eb2848

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rtpascual rtpascual merged commit 9dcd092 into main Nov 15, 2024
40 checks passed
@rtpascual rtpascual deleted the cleanup-env-files branch November 15, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants