add optional timeout property to ConversationHandlerFunctionProps and use in ConversationHandlerFunction #2349
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
ConversationHandlerFunction times out when doing long running tool requests. timeout parameter is added to cover those edge cases by the developer. Running tools can take longer than 60 seconds for some special cases like generating assets like images or videos by other LLMs as a response to a tool request. Therefore the timeout for the conversation handler function should be flexible to be changed by the developer if needed.
Issue number, if available:
Changes
Introduce optional timeout parameter (typeof Duration) to ConversationHandlerFunctionProps and use in ConversationHandlerFunction constructor to define optionally another timeout than the default 60s.
Corresponding docs PR, if applicable:
Validation
Change has been tested locally with long running dummy tool that delays answer to 2 minutes.
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.