Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add form cli #255
Add form cli #255
Changes from 126 commits
9b38e20
ac18f6e
6a2d000
c35a826
db6c0a7
b97e5d3
1c85615
f3ce015
498e4d0
eb61d43
889e429
5ce0fa0
0cc548d
7ad8ddd
cc68d7f
0421e08
6a7d171
d8930db
3d1baab
700708f
0ff1d34
b85bc3d
cae1e4e
c81f521
cf87b25
943f33e
1270dd0
7568fc1
2d6a1a4
e1b742a
f1a531b
428a4fc
0fedd44
1178c1a
b6a3924
30c75e9
88c11ba
9efed24
7d8f787
17f5606
984ead9
9533ca5
32e701a
2538ef6
cc77a10
b4c272c
b0fe138
24c06a8
5550dae
a3da6d7
2ab0912
91d387d
4049c9a
6facb2a
e3098d4
5e293a1
dfb989c
449cfa0
2fba70b
9512f2d
891bc9c
9b25295
ae9fee7
aa43e60
caa5909
fdc1f07
1d33131
bb0352c
716346c
3dba28d
fb22ff8
45f9ddd
ee4b95f
c16b752
74a190d
aac700e
49c5001
0982244
d7a822d
c344700
bb40177
9ffaaf6
01cdf1a
101f789
3058644
1ff5397
a0109d5
4c1c178
7217e7a
f2c4b61
032d6de
f27b6e6
0f41b83
e860973
e77b72b
5bce561
04ebf4b
1bed20f
d3df4d9
35bd35c
313ec94
0c3f3c7
18b650f
05a59e1
92b80d1
ac31c8f
e3080e3
e26d1ad
0f47bdc
d991b62
f2cd27f
2fd0151
111246f
5e361c0
34d13ef
3641d52
64b294e
3e2c5b2
155421a
988fdb0
0b7c5b9
d0f1fa7
0a07970
53007db
c6e99e3
89246a1
b2ff0af
c4fb1f7
d1bdb00
2058bd5
87e76d7
a07c2c0
140bba9
0f63252
f7f6207
e3a69fe
d2a441a
85cd8f2
4d6137f
a94e8b2
cb0f829
6dfef13
eb61726
732d7fc
6c544ec
4f026d9
727b81b
090fefe
7c6fa22
ea11d6e
ad97f35
771902f
164a274
acc4a67
e57b97d
c5eaeb1
c6a72da
e6ad96c
ac49470
8d7a51a
3040262
2600896
9674adc
9014015
143c3ae
a8c60d9
86d2e87
f4f53f3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is sneaky!
#250 (review)
will bring
Printer
. Can you work with @hoangnbn to bring this in and replace this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm removing this altogether. We should come up with an event system where we can log UI, log analytics events, etc, from these commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logs and analytics yes. UI is trickier as sequence of messages may matter.