-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate client code command #265
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 57152fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alharris-at
force-pushed
the
generate-client-code-command
branch
from
September 21, 2023 20:56
e219691
to
cb03274
Compare
alharris-at
commented
Sep 21, 2023
...s/cli/src/commands/generate/graphql-client-code/generate_graphql_client_code_command.test.ts
Outdated
Show resolved
Hide resolved
alharris-at
commented
Sep 21, 2023
alharris-at
force-pushed
the
generate-client-code-command
branch
2 times, most recently
from
September 22, 2023 00:29
248f7ce
to
9a60b3d
Compare
alharris-at
force-pushed
the
generate-client-code-command
branch
from
September 22, 2023 15:58
9a60b3d
to
dbadc31
Compare
alharris-at
requested review from
edwardfoyle,
sobolk and
Amplifiyer
as code owners
September 22, 2023 16:08
sobolk
reviewed
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
packages/cli/src/commands/generate/generate_command_factory.test.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/commands/generate/graphql-client-code/generate_graphql_client_code_command.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/commands/generate/graphql-client-code/generate_graphql_client_code_command.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/commands/generate/graphql-client-code/generate_graphql_client_code_command.ts
Outdated
Show resolved
Hide resolved
.../src/commands/generate/graphql-client-code/generate_graphql_client_code_generator_adapter.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/commands/generate/graphql-client-code/mock_code_generator.ts
Outdated
Show resolved
Hide resolved
…st.ts fix: update test name Co-authored-by: Kamil Sobol <[email protected]>
Merged
…simplifying until we have an impl in place
sobolk
previously approved these changes
Sep 25, 2023
sobolk
reviewed
Sep 25, 2023
sobolk
approved these changes
Sep 25, 2023
dpilch
approved these changes
Sep 25, 2023
abhi7cr
pushed a commit
that referenced
this pull request
Sep 27, 2023
* feat: add mocked generate graphql-client-code to cli * Update packages/cli/src/commands/generate/generate_command_factory.test.ts fix: update test name Co-authored-by: Kamil Sobol <[email protected]> * chore: add missing descriptions for targets, use new shared backendIdentifierResolver * chore: remove adapter, we may need to reintroduce in the future, but simplifying until we have an impl in place * chore: add feature flags * chore: flip to use real generator, not mocked api --------- Co-authored-by: Kamil Sobol <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Add the
generate graphql-client-code
command to the CLI.Help Output:
Extended Help Output (including all feature flags):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.