Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate api code #269
feat: generate api code #269
Changes from all commits
4af3bd8
245a5b3
0728b7e
144d40d
7452e45
138da96
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more suggestion.
Rest of APIs are explicit about
Graphql
Should we use
generateGraphqlApiCode
(and similar in props/return) ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rene wanted customer facing APIs to use "API" over "Graphql". We'll be syncing with him on naming next week to finalize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we'll be able to close on this by EOD Monday, but I wouldn't make it block this, since we want this in for the pentest ready date, which is also monday (easy to change)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also. Then
If this is customer facing I suggest to consider moving other types to namespaces.
So that
import * as generator from '@aws-amplify/model-generator'
does not cause explosion in IDE when customer typesgenerator.
.For example other types can be moved to
@aws-amplify/model-generator/documents
@aws-amplify/model-generator/types
what not. We do that in other packages that are customer facing like here:https://github.com/aws-amplify/samsara-cli/blob/4fd18b126ba075d054ddc4b34859e67e519355e5/packages/client-config/package.json#L8-L18