-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support jest 26 cjs loading of packages #286
Conversation
🦋 Changeset detectedLatest commit: ba74158 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some dummy CJS package to our repo or generate one in integration tests and add dependency on packages that have to support CJS ?
Issue #, if available:
Description of changes:
The graphql construct package uses jest 26 which does not support loading es6 modules. Because these tests need to load the
backend-output-schemas
andbackend-output-storage
packages, we need to expose a "main" field on the package.json so that the jest cjs loader can find the package entry point.Tested by running the gql construct test suite locally with this change
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.