Sandbox hooks #298
Closed
Sandbox hooks #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kamil Sobol <[email protected]>
…nto sandbox-hooks
Co-authored-by: Amplifiyer <[email protected]>
* feat: sandbox options add format * test: add format to available options * fix: sandbox command option format * add changeset * chore: update API.md * refactor: move get_config_path to client-config * chore: type and lint * chore: update API.md * chore: import formatChoices to sandbox * chore: change template literal * chore: update types, use Enum * chore: update types for FormatOption * chore: fix type * chore: move getConfigPath to internal api * chore: rename getClientConfigPath * chore: rename FormatChoice * chore: update API.md * chore: add index.js to internal.ts * chore: remove configFileName and formatChoices from API * fix: test * sandbox: initial implementation of deployment hooks * sandbox: simplify hook registration example * lint: fix lints * refactor: use events instead of hooks * api: update api description files * logging: added debug logging * tests: fix broken test * sandbox: base event handler on node:events EventEmitter * tests: fix broken test * chore: move getConfigPath from GenerateConfigCommand to generateClientConfigToFile * Update packages/client-config/src/paths/get_client_config_path.ts Co-authored-by: Kamil Sobol <[email protected]> * chore: rename FormatChoice to ClientConfigFormat * refactor: generateClientConfigToFile to accept out and format * test: update tests for generate config and sandbox * Update packages/cli/src/commands/sandbox/sandbox_command.ts Co-authored-by: Edward Foyle <[email protected]> * test: misc var change * chore: move ClientConfigFormat to public API * chore: update API.md * test: add test for getClientConfigPath * test: use path.join to resolve windows slash * test: use path.join to resolve windows slash * chore: fix linting error * chore: fix linting error * chore: remove defaultOptions * test: add asserts for both out and format * test: add absolut path test * fix: throw error if provided file path * fix: broken test * fix: integrate format into event callback * api: update api description files * fix: address pr comments * chore: rename --out to --outDir * fix: use lstatSync to detect file path * chore: update API.md * chore: changeset * chore: remove un-used var * fix: package-lock resolve registry * chore: ignore spell of lstat * chore: refactor mock-fs with node:mock * chore: remove un-used var * chore: make getClientConfigPath async * fix: path for windows * chore: remove auto-generated changelogs * fix: remove references to deleted events * api: update api description files * refactor: rename event, move generate-config-adapter * refactor: remove sandbox config adapter * refactor: use args.out directly for config write path * refactor: use exported getClientConfigPath from client-config package * refactor: use mocks for test * fix: explicitly export getClientConfigPath * Update packages/sandbox/src/file_watching_sandbox.ts Co-authored-by: Kamil Sobol <[email protected]> * fix: remove unused import * Update packages/cli/src/commands/sandbox/sandbox_command.ts Co-authored-by: Amplifiyer <[email protected]> * refactor: extract getBackendIdentifier * test: add test to validate that successfulDeployment event is emitted * test: refactor to allow asserting that a specific callback was registered * fix: remove unused import * refactor: creator method for registering sandbox events * fix: remove unused import * fix: fix naming, refactor for readability --------- Co-authored-by: MJ☔ <[email protected]> Co-authored-by: MJ Zhang <[email protected]> Co-authored-by: Kamil Sobol <[email protected]> Co-authored-by: Edward Foyle <[email protected]> Co-authored-by: Amplifiyer <[email protected]>
…li into sandbox-hooks
sdstolworthy
requested review from
edwardfoyle,
sobolk and
Amplifiyer
as code owners
🦋 Changeset detectedLatest commit: f0b70c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sdstolworthy
added
the
run-e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.