test: include sandbox in canary tests #612
Conversation
🦋 Changeset detectedLatest commit: a2f983a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| void describe('pipeline deployment', () => { | ||
| let tempDir: string; | ||
| let testBranch: TestBranch; |
There was a problem hiding this comment.
enabling parallelization requires nesting of these variables
| @@ -123,8 +123,16 @@ export const amplifyCli = ( | |||
| ): ProcessController => { | |||
| let command: string; | |||
| if (options?.installationType === 'local') { | |||
There was a problem hiding this comment.
Could we get rid of this if statement and do the lookup unconditionally?
There was a problem hiding this comment.
easy to try.
If it works it works. if not we'll keep this.
There was a problem hiding this comment.
Tests are happy, we can do it.
| // See: https://github.com/aws-amplify/amplify-backend/issues/582 | ||
| command = execaSync('npx', ['which', 'amplify'], { | ||
| cwd: dir, | ||
| }).stdout; |
There was a problem hiding this comment.
do we need a .trim() here?
Issue #, if available:
Description of changes:
This change adds sandbox to canary test suite.
There's one workaround applied to locate amplify binary in local installation. Better solution will be pursued here #582 .
Canary run from branch https://github.com/aws-amplify/amplify-backend/actions/runs/6816085805 .
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.