test: fix create amplify installation in canary tests #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 80de5ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
srquinn21
approved these changes
Nov 13, 2023
0618
approved these changes
Nov 13, 2023
sobolk
commented
Nov 13, 2023
Comment on lines
+40
to
+47
| // Force 'create-amplify' installation in npx cache by executing help command | ||
| // before tests run. Otherwise, installing 'create-amplify' concurrently | ||
| // may lead to race conditions and corrupted npx cache. | ||
| await execa('npm', ['create', 'amplify', '--yes', '--', '--help'], { | ||
| // Command must run outside of 'amplify-backend' workspace. | ||
| cwd: os.homedir(), | ||
| stdio: 'inherit', | ||
| }); |
There was a problem hiding this comment.
Discussed with @Amplifiyer offline. and logged #637 to seek better solution.
edwardfoyle
approved these changes
Nov 13, 2023
Amplifiyer
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Fixes race condition that has been showing up in canary tests. I.e. it seems that running
create-amplifywith cold cache can result in corruption.Sample logs:
Test run
https://github.com/aws-amplify/amplify-backend/actions/runs/6853040384/job/18632951365
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.