Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include only required userAttributes and generate identityPoolName in backend file #13994

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

Sanayshah2
Copy link
Contributor

@Sanayshah2 Sanayshah2 commented Oct 23, 2024

Description of changes

  • Filter userAttributes to include only required attributes and not all Standard Attributes in auth/resource.ts
  • Set userNameAtttributes to undefined instead of [] in backend.ts
  • Modify codegen to include identityPoolName in backend.ts

Description of how you validated changes

Manually creating an application and running migrate command and checking the generated code. Unit tests.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Sanayshah2 Sanayshah2 requested a review from a team as a code owner October 23, 2024 23:53
@Sanayshah2 Sanayshah2 changed the title fix: include only required userAttributes and generate identityPoolNa… fix: include only required userAttributes and generate identityPoolName in backend file Oct 24, 2024
@Sanayshah2 Sanayshah2 merged commit 83871a2 into aws-amplify:migrations Oct 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants