-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration: Codegen support for Gen2 reference auth from Gen1 import auth #14011
Conversation
const mockUserPoolID = 'UserPoolId'; | ||
const mockIdentityPoolName = 'mockIdentityPoolName'; | ||
const mockIdentityPoolId = 'IdentityPoolId'; | ||
const mockAppClientId = 'AppClientID'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are we doing about the other client id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think import auth in gen1 needs only 1 client (web): https://docs.amplify.aws/gen1/javascript/build-a-backend/auth/import-existing-resources/
Description of changes
Add Codegen support for Gen2 reference auth from Gen1 import auth.
Note: we codegen the references to all the userpool groups by default. Users could later remove the ones they don't need to reference in other categories.
Example output:
Description of how you validated changes
Ran codegen command, updated Gen2 backend package to a tagged release that supports
refAuth
and rannpx sandbox deploy
.Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.