Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added user pool client codegen #14016

Merged
merged 5 commits into from
Nov 27, 2024
Merged

fix: added user pool client codegen #14016

merged 5 commits into from
Nov 27, 2024

Conversation

bzsurbhi
Copy link

Description of changes

  • Added codegen for userPoolClient configuration
  • Added retain policy for identity pool, user pool and s3 bucket
  • Fixed a bug in s3 encryption algorithm codegen

Description of how you validated changes

Added unit tests

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bzsurbhi bzsurbhi requested a review from a team as a code owner November 18, 2024 06:57
@bzsurbhi bzsurbhi merged commit 2ffc5a8 into aws-amplify:migrations Nov 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolk sobolk sobolk approved these changes

@abhi7cr abhi7cr abhi7cr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzsurbhi @abhi7cr @sobolk