Gen2 migrations fixes #14045
Merged
Gen2 migrations fixes #14045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
abhi7cr
force-pushed
the
gen2-migrations-execute
branch
from
1e3c57b to
b1ca1b1
Compare
abhi7cr
commented
Dec 18, 2024
| @@ -179,13 +180,17 @@ const unsupportedCategories = (): Map<string, string> => { | |||
| Object.keys(apiList).forEach((api) => { | |||
| const apiObj = apiList[api]; | |||
| if (apiObj.service == 'API Gateway') { | |||
| unsupportedCategoriesList.set('rest api', unsupportedCategories.get('rest api')!); | |||
| const restAPIDocsLink = unsupportedCategories.get(restAPIKey); | |||
abhi7cr
commented
Dec 18, 2024
| } | ||
| }); | ||
| } | ||
| } else { | ||
| if (unsupportedCategories.has(category) && Object.entries(meta[category]).length > 0) { | ||
| unsupportedCategoriesList.set(category, unsupportedCategories.get(category)!); | ||
| const unsupportedCategoryDocLink = unsupportedCategories.get(category); |
aws-aemilia
approved these changes
Dec 18, 2024
bzsurbhi
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Description of how you validated changes
yarn test, manual testing of running gen2 codegenChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.