fix: Add exports to build customer declaration files for combine schema #386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Description of changes:
This change expands the tests originally created by @stocaaro. It introduces a new e2e test application that fails to build due to missing exports needed to construct customer
*.d.ts
project files.The change then introduces the missing exports to
@aws-amplify/data-schema
needed to get this build to work.Example of why we need this:
Customers with combine schema get compiler errors when they enable declarations in their compilerOptions:
Results in the compile error:
The inferred type of 'buildCombineSchema' cannot be named without a reference to '../node_modules/@aws-amplify/data-schema/dist/esm/CombineSchema'. This is likely not portable. A type annotation is necessary.
This change adheres to the rules regarding new exported types to prevent breaking changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.