Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): add 'initialValues' type to 'observeQuery' #39

Closed
wants to merge 4 commits into from

Conversation

david-mcafee
Copy link

@david-mcafee david-mcafee commented Nov 7, 2023

Issue #, if available:

Description of changes:
Adds initialValues type to 'observeQuery'.

Corresponding feature PR

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: 5312509

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/amplify-api-next-types-alpha Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@david-mcafee david-mcafee requested a review from a team November 7, 2023 03:47
@david-mcafee david-mcafee marked this pull request as ready for review November 7, 2023 17:30
@@ -0,0 +1 @@
cookie
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not actually sure what this is or what it's used for. Do we need it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's some kind of turbo repo artifact, but we shouldn't commit it. Let's delete this from git and add .turbo-cookie > .gitignore

Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit re: .turbo-cookie, but otherwise LGTM

@david-mcafee
Copy link
Author

Descoped for now, closing this PR.

@david-mcafee david-mcafee deleted the observe-query-initial-values branch August 23, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants