Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data): add types for custom headers #53

Merged
merged 10 commits into from
Nov 11, 2023
Merged

feat(data): add types for custom headers #53

merged 10 commits into from
Nov 11, 2023

Conversation

david-mcafee
Copy link

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: 7d9ec1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/data-schema-types Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@david-mcafee david-mcafee requested a review from a team November 10, 2023 21:08
@david-mcafee david-mcafee marked this pull request as ready for review November 10, 2023 23:27
package-lock.json Outdated Show resolved Hide resolved
Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would prefer to see the package-lock reverted vs regenerated if possible

@david-mcafee david-mcafee changed the title feat(data): add custom header support to data schema client feat(data): add types for custom headers Nov 10, 2023
@david-mcafee
Copy link
Author

LGTM, but would prefer to see the package-lock reverted vs regenerated if possible

Note: the package-lock regeneration was reverted.

@david-mcafee david-mcafee deleted the tb-headers branch November 11, 2023 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants