fix(actions): no longer send empty string values #4016
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjnoyp
reviewed
Oct 27, 2023
actions/bin/log_cw_metric.dart
Outdated
| @@ -60,8 +62,8 @@ Future<void> logMetric() async { | |||
| */ | |||
|
|
|||
| // Inputs for Metric | |||
| final metricName = core.getRequiredInput('metric-name'); | |||
| final testType = core.getRequiredInput('test-type'); | |||
| final metricName = core.getRequiredInput('metric-name') ?? defaultValue; | |||
There was a problem hiding this comment.
We shouldn't have defaultValue for requiredInput as an exception should be thrown if a value is not supplied here. Also for testType, we throw if an improper value is given anyway below.
haverchuck
force-pushed
the
fix/send-none-vals-to-metrics
branch
3 times, most recently
from
b7a1f70 to
ad31cd2
Compare
This reverts commit 0427860.
haverchuck
force-pushed
the
fix/send-none-vals-to-metrics
branch
from
2bc57fa to
ebe3559
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Stops sending empty strings in cw metric dimensions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.