chore(smithy,auth): Dart 3.3.0 Beta Analysis Errors #4354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
105
to
106
| // TODO(equartey): Use `(langCodepageArr + i).ref` when Dart 3.30 is released. | ||
| // ignore: deprecated_member_use |
There was a problem hiding this comment.
Questions:
- Should this be 3.3.0 instead of 3.30?
- Is
.refnew in dart 3.3? If so, we cannot use it until our min version is 3.3 - Do we know when elementAt is being removed? I would assume not until at least 4.0 but would be goo to confirm
There was a problem hiding this comment.
- Opps, yeah typo. Meant 3.3.0
.refis not new, rather 3.3.0 is deprecatingelementAt()and the+operator is the replacement. I will update that comment too.- Not sure if 4.0 or 3.4 reference
NikaHsn
previously approved these changes
Jan 17, 2024
Equartey
changed the title
Jordan-Nelson
previously approved these changes
Jan 17, 2024
packages/auth/amplify_auth_cognito_dart/lib/src/asf/asf_device_info_collector.windows.dart
Outdated
Show resolved
Hide resolved
Jordan-Nelson
approved these changes
Jan 17, 2024
NikaHsn
approved these changes
Jan 17, 2024
NikaHsn
pushed a commit
that referenced
this pull request
Jan 26, 2024
NikaHsn
pushed a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Dart 3.30 beta introduces new lint failures. This provides fixes for failing tests:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.