Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(smithy): fix smithy codegen generated code format issue #4410

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

NikaHsn
Copy link
Member

@NikaHsn NikaHsn commented Jan 30, 2024

Issue #, if available:

Context:

  • fix the smithy codegen ci build issue related to build_runner generated code format issue link

Description of changes:

  • update dart_style version to ^2.3.2 (we can not bump the version because pigeon >=10.0.1 <13.1.2 depends on analyzer ^5.13.0 and dart_style >=2.3.3 depends on analyzer ^6.2.0, pigeon >=10.0.1 <13.1.2 is incompatible with dart_style >=2.3.3.)
  • update code_builder version to 4.10.0.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@NikaHsn NikaHsn requested a review from a team as a code owner January 30, 2024 16:48
@NikaHsn NikaHsn force-pushed the chore/smithy-codegen branch from 010d6dd to a9d2461 Compare January 30, 2024 17:05
Equartey
Equartey previously approved these changes Jan 30, 2024
Jordan-Nelson
Jordan-Nelson previously approved these changes Jan 30, 2024
@NikaHsn NikaHsn dismissed stale reviews from Jordan-Nelson and Equartey via f70ae0c January 30, 2024 19:59
@NikaHsn NikaHsn merged commit e2847bd into main Jan 30, 2024
129 checks passed
@Equartey Equartey deleted the chore/smithy-codegen branch January 31, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants