Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common,notifications): update os_detect to 2.0.2 #5569

Merged
merged 2 commits into from
Oct 18, 2024
+22 −22
Merged

chore(common,notifications): update os_detect to 2.0.2 #5569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc37425
chore(common,notifications): update os_detect to 2.0.2
tyllark Oct 17, 2024
0282976
chore(common): removed OperatingSystem constants
tyllark Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aft/test/version_bump/data/repo_snapshot/packages/aws_common/pubspec.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ...mp/data/repo_snapshot/packages/notifications/push/amplify_push_notifications/pubspec.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/aws_common/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ dependencies:
logging: ^1.0.0
meta: ^1.7.0
mime: ^1.0.0
os_detect: ^2.0.0
os_detect: ^2.0.2
path: ">=1.8.0 <2.0.0"
stream_transform: ^2.0.0
uuid: ">=3.0.6 <5.0.0"
Expand Down
18 changes: 9 additions & 9 deletions packages/aws_common/test/config/file_location_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ void main() {
r'User home is loaded from $HOME with highest priority on non-windows platforms.',
() {
overrideOperatingSystem(
const OperatingSystem('linux', ''),
OperatingSystem('linux', ''),
() {
overrideEnvironment(
{
Expand Down Expand Up @@ -42,7 +42,7 @@ void main() {
r'User home is loaded from $HOME with highest priority on windows platforms.',
() {
overrideOperatingSystem(
const OperatingSystem('windows', ''),
OperatingSystem('windows', ''),
() {
overrideEnvironment(
{
Expand Down Expand Up @@ -70,7 +70,7 @@ void main() {
r'User home is loaded from $USERPROFILE on windows platforms when $HOME is not set.',
() {
overrideOperatingSystem(
const OperatingSystem('windows', ''),
OperatingSystem('windows', ''),
() {
overrideEnvironment(
{
Expand All @@ -97,7 +97,7 @@ void main() {
r'User home is loaded from $HOMEDRIVE$HOMEPATH on windows platforms when $HOME and $USERPROFILE are not set.',
() {
overrideOperatingSystem(
const OperatingSystem('windows', ''),
OperatingSystem('windows', ''),
() {
overrideEnvironment(
{
Expand All @@ -123,7 +123,7 @@ void main() {
r'The default config location can be overridden by the user on non-windows platforms.',
() {
overrideOperatingSystem(
const OperatingSystem('linux', ''),
OperatingSystem('linux', ''),
() {
overrideEnvironment(
{
Expand All @@ -149,7 +149,7 @@ void main() {
r'The default credentials location can be overridden by the user on non-windows platforms.',
() {
overrideOperatingSystem(
const OperatingSystem('linux', ''),
OperatingSystem('linux', ''),
() {
overrideEnvironment(
{
Expand All @@ -175,7 +175,7 @@ void main() {
r'The default credentials location can be overridden by the user on windows platforms.',
() {
overrideOperatingSystem(
const OperatingSystem('windows', ''),
OperatingSystem('windows', ''),
() {
overrideEnvironment(
{
Expand All @@ -201,7 +201,7 @@ void main() {
r'The default credentials location can be overridden by the user on windows platforms.',
() {
overrideOperatingSystem(
const OperatingSystem('windows', ''),
OperatingSystem('windows', ''),
() {
overrideEnvironment(
{
Expand All @@ -226,7 +226,7 @@ void main() {
test(r'The default profile can be overridden via environment variable.',
() {
overrideOperatingSystem(
const OperatingSystem('linux', ''),
OperatingSystem('linux', ''),
() {
overrideEnvironment(
{
Expand Down
2 changes: 1 addition & 1 deletion packages/aws_common/tool/generate_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ void main() {
output.writeln(
'''
test(r'${test.name}', () {
overrideOperatingSystem(const OperatingSystem('${test.platform.name}', ''), () {
overrideOperatingSystem(OperatingSystem('${test.platform.name}', ''), () {
overrideEnvironment({
${test.environment.entries.map((entry) => "'${entry.key}': r'${entry.value}',").join('\n')}
}, () {
Expand Down
2 changes: 1 addition & 1 deletion packages/notifications/push/amplify_push_notifications/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ dependencies:
flutter:
sdk: flutter
flutter_plugin_android_lifecycle: ^2.0.9
os_detect: ^2.0.0
os_detect: ^2.0.2
shared_preferences: ^2.0.15

dev_dependencies:
Expand Down
14 changes: 7 additions & 7 deletions ...ifications/push/amplify_push_notifications/test/amplify_push_notifications_impl_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ void main() {

test('should register background processor on Android', () async {
await overrideOperatingSystem(
const OperatingSystem('android', ''),
OperatingSystem('android', ''),
() async {
when(mockPushNotificationsHostApi.getLaunchNotification()).thenAnswer(
(_) async => standardAndroidPushMessage.cast(),
Expand Down Expand Up @@ -254,7 +254,7 @@ void main() {
);

overrideOperatingSystem(
const OperatingSystem('ios', ''),
OperatingSystem('ios', ''),
() {
expect(
() async => plugin.setBadgeCount(42),
Expand Down Expand Up @@ -388,7 +388,7 @@ void main() {
});
test('getBadgeCount returns a badge count', () async {
await overrideOperatingSystem(
const OperatingSystem('ios', ''),
OperatingSystem('ios', ''),
() async {
plugin = TestAmplifyPushNotifications(
serviceProviderClient: mockServiceProviderClient,
Expand All @@ -415,7 +415,7 @@ void main() {

test('setBadgeCount calls the native layer to set', () async {
await overrideOperatingSystem(
const OperatingSystem('ios', ''),
OperatingSystem('ios', ''),
() async {
plugin = TestAmplifyPushNotifications(
serviceProviderClient: mockServiceProviderClient,
Expand Down Expand Up @@ -487,7 +487,7 @@ void main() {
'onNotificationReceivedInBackground throws an Exception when the given callback function is not top-level or static',
() async {
overrideOperatingSystem(
const OperatingSystem('android', ''),
OperatingSystem('android', ''),
() {
plugin = TestAmplifyPushNotifications(
serviceProviderClient: mockServiceProviderClient,
Expand All @@ -514,7 +514,7 @@ void main() {
'onNotificationReceivedInBackground should register a top-level or static callback function',
() async {
await overrideOperatingSystem(
const OperatingSystem('android', ''),
OperatingSystem('android', ''),
() async {
SharedPreferences.setMockInitialValues({});
final pref = await SharedPreferences.getInstance();
Expand All @@ -534,7 +534,7 @@ void main() {
test('onNotificationReceivedInBackground should accept the callback on iOS',
() async {
overrideOperatingSystem(
const OperatingSystem('ios', ''),
OperatingSystem('ios', ''),
() {
void localiOScallback(testGlobalCallbackFunction) {}
plugin = TestAmplifyPushNotifications(
Expand Down
2 changes: 1 addition & 1 deletion ...otifications/push/amplify_push_notifications/test/push_notification_flutter_api_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ void main() {
'should invoke the top-level or static external callback function on Android',
() async {
await overrideOperatingSystem(
const OperatingSystem('android', ''),
OperatingSystem('android', ''),
() async {
final pref = await SharedPreferences.getInstance();
TestAmplifyPushNotifications(
Expand Down
Loading