Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add steps to auto update changelog in kickoff PR #32

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

5d
Copy link
Contributor

@5d 5d commented Oct 3, 2024

Issue #, if available:

Description of changes:

  • add steps in kickoff workflow to generate and append changelog message to the file.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@5d 5d requested a review from a team as a code owner October 3, 2024 00:45
@5d 5d force-pushed the 5d/update-changelog-on-kickoff branch from 7f0ce19 to d5e0f63 Compare October 3, 2024 19:46

{
if (NF > 0) { # Skip empty lines
if (tolower($1) == "feat:") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work with messages with a slightly different format, such as feat(<something>): <message>, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this only works for feat:. As this repo is only for the apollo extension, we don't have other components.

} else if (tolower($1) == "fix:") {
add_to_group("Fixes:", substr($0, index($0, $2)))
} else if (tolower($1) == "chore:") {
add_to_group("MISC:", substr($0, index($0, $2)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intentional for this repo? We generally don't report chore tasks in the changelogs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will remove it.

@5d 5d force-pushed the 5d/update-changelog-on-kickoff branch from d5e0f63 to dac53e0 Compare October 3, 2024 20:26
@5d 5d deployed to IntegTest October 3, 2024 20:26 — with GitHub Actions Active
@5d 5d merged commit 6878467 into main Oct 3, 2024
9 checks passed
@5d 5d deleted the 5d/update-changelog-on-kickoff branch October 3, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants