-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add steps to auto update changelog in kickoff PR #32
Conversation
7f0ce19
to
d5e0f63
Compare
|
||
{ | ||
if (NF > 0) { # Skip empty lines | ||
if (tolower($1) == "feat:") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work with messages with a slightly different format, such as feat(<something>): <message>
, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this only works for feat:
. As this repo is only for the apollo extension, we don't have other components.
} else if (tolower($1) == "fix:") { | ||
add_to_group("Fixes:", substr($0, index($0, $2))) | ||
} else if (tolower($1) == "chore:") { | ||
add_to_group("MISC:", substr($0, index($0, $2))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intentional for this repo? We generally don't report chore
tasks in the changelogs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 will remove it.
d5e0f63
to
dac53e0
Compare
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.