[DBClusterParameterGroup] Enforce that "aurora_enhanced_binlog" and "binlog_backup" get bundled in the same ModifyDBParameterGroup request #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…binlog_backup" get bundled in the same request to ModifyDBParameterGroup
zrfr
approved these changes
Jul 8, 2024
angusy29
approved these changes
Jul 8, 2024
ccmlst
reviewed
Jul 8, 2024
| ResourceModel resourceModel = RESOURCE_MODEL.toBuilder() | ||
| .parameters(InsertionOrderedParamBuilder.builder() | ||
| .addParameter("aurora_enhanced_binlog", "1") | ||
| .addRandomParameters(BaseHandlerStd.MAX_PARAMETERS_PER_REQUEST) |
There was a problem hiding this comment.
would be good to add hardcoded parameters that should not be bundle and that they existed in 2 separate requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are combinations of ParameterGroups that ModifyDBParameterGroup expected them come in the same request, as they are related and configure a particular functionality. At the same time, the ModifyDBParameterGroup API expects a maximum of 20 parameters that can be modified in a single request. (https://docs.aws.amazon.com/cli/latest/reference/rds/modify-db-parameter-group.html)
In the case that the parameters included in the CFN template exceed the request limit, we could end up in a condition in which 2 related parameters existing in the CFN template, end up in 2 different requests. We need to ensure that all related parameters are sent in the same request.