fix(DBInstance): handle cases where both previous and desired allocated storage are null #557
Conversation
…ed storage are null
| .build(); | ||
| final ResourceModel desiredModel = RESOURCE_MODEL_BLDR() | ||
| .allocatedStorage(null) | ||
| .storageType(STORAGE_TYPE_IO1) |
There was a problem hiding this comment.
Yes, max() function only involved when it is a ProvisionedIoStorage.
https://github.com/aws-cloudformation/aws-cloudformation-resource-providers-rds/blob/master/aws-rds-dbinstance/src/main/java/software/amazon/rds/dbinstance/Translator.java#L496
|
This bug fix is completely inscrutable and took me some time to figure out. For the benefit of anyone else who comes across this change: the bug was that the max function crashed with an NPE when both of the arguments were null. The cause was due to how Java's conditional/ternary expression handles types (see JLS). Java determines the type of a conditional expression based on the second and third operands. If one operand is a primitive type and the other is a boxed number, then the expression's type is primitive, requiring the boxed operand to be unboxed. This crashes if the operand is null. The fix works by forcing the expression's type to be boxed, which avoids the unboxing conversion. I didn't manage to review this before we merged it, but I would have preferred a more understandable fix. |
This change addresses an issue causing DB instance updates to fail during rollback with an InternalFailure. The error message was "Cannot invoke 'java.lang.Integer.intValue()' because 'b' is null". The fix ensures the max() function can handle null inputs.