Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore - Fix reformatter conflicts between eclipse java formatter and pre commit checks #581

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

angusy29
Copy link
Contributor

Context: When you run mvn package, it uses the Eclipse Java Formatter: https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/blob/master/src/main/resources/com/amazonaws/cloudformation/eclipse-java-formatter.xml#L1

But the pre-commit hook we use has a different set of reformatting rules, which conflict with the Eclipse Java Formatter.

Problem

This means, whenever you run mvn package to build the project, your project gets reformatted via the eclipse formatter, but maven verify step in our build process runs lint checks from the pre-commit hook - these 2 conflict, meaning everytime you build the project with mvn package your project WILL reformat itself.

Description of changes:

This change commits:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant