Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing memberType from mcastGroupSource & sourceType from mcastGrou… #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

suhaniladani
Copy link
Contributor

@suhaniladani suhaniladani commented Jan 17, 2023

Conform with the contract test v2 rules

Since these resource TgwMcastGroupSource & TgwMcastGroupMember are based on a common resource TgwMcastGroup, each resource has some properties which may not be necessarily displayed in each read request based on the resource type (Member or Source). But according to the contract test v2, each readOnly property needs to be displayed in the readRequest. Making the following changes to conform with the contract test consistency standards.

Issue #, if available:
This is still not complete set of changes to make the contract test v2 fully work. Next steps:

  • Add integ test for List resources in integ test package
  • Ask CFN for exception from the ListResources Tests.

Description of changes:

  • Removing the property sourceType from under readOnly properties in mcastGroupMember to conform with the contract test v2 rules.
  • Removing the property memberType from under readOnly properties in mcastGroupSource to conform with the contract test v2 rules.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

…pMember as readOnly properties to conform with the contract test v2 rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant