Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep multi-repo consistent with single-repo for helm values configuration. #1719

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

ajpaws
Copy link
Contributor

@ajpaws ajpaws commented Aug 9, 2023

Description

Motivation and Context

How was this change tested?

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Yes, I have updated the docs for this feature
  • Yes, I ran pre-commit run -a with this PR

Additional Notes

@ajpaws ajpaws requested a review from a team as a code owner August 9, 2023 05:34
@bryantbiggs
Copy link
Contributor

could we add details on what the motivation is for this change, does this fix or improve something, etc. When I first read the title I had assumed the multiple sub-directories would have been flattened to a single directory but this appears to be just helm value changes

@ajpaws
Copy link
Contributor Author

ajpaws commented Aug 9, 2023

This is a fix. currently, the helm values from main.tf in eks_cluster module are not passed to the multi-repo Application. These changes are required to fix it similar to how the helm values are passed to single_repo example application

@rodrigobersa rodrigobersa changed the title to keep multi-repo consistent with single-repo for helm values confi… fix: Keep multi-repo consistent with single-repo for helm values configuration. Aug 9, 2023
@rodrigobersa
Copy link
Contributor

Hi @ajpaws!

Can you open an Issue, regarding this scenario and explain the actual vs expected behavior. Then update the comment in the Motivation and Content section.

Best,

@ajpaws
Copy link
Contributor Author

ajpaws commented Aug 10, 2023

Hi @ajpaws!

Can you open an Issue, regarding this scenario and explain the actual vs expected behavior. Then update the comment in the Motivation and Content section.

Best,

@bryantbiggs I created the Issue #1722

@rodrigobersa rodrigobersa temporarily deployed to EKS Blueprints Test August 10, 2023 16:21 — with GitHub Actions Inactive
Copy link
Contributor

@rodrigobersa rodrigobersa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and the Issue @ajpaws.

@bryantbiggs bryantbiggs merged commit 711525c into aws-ia:main Aug 13, 2023
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

passing helm values configuration for multi-repo app from terraform is not working
3 participants