-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Enable EventBridge rules/targets before EKS cluster #1728
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vchintal please see the error in the CI check.
Hi @askulkarni2, it is a known issue unfortunately. Since we do not run all of the TF at once, we cannot expect the TF plan to succeed. If you see in the README we have broken this up into two TF apply commands. If the first command is run and then the TF plan is run, it will succeed. Let me know if this explanation makes sense. |
Gotcha. Can you please update the github workflow to skip this blueprint then? |
@askulkarni2 Sure, can do! Can you please point me to where I have to make the necessary changes? I haven't done this before and do not want to assume. |
Sure, it would just be under https://github.com/aws-ia/terraform-aws-eks-blueprints/blob/main/.github/scripts/plan-examples.py. |
@askulkarni2 Think I have done it right, please check the latest commit. Thanks 🙏🏼 |
Description
The eventbridge target for the rule
eks-api-endpoint-create
wasn't getting created with the firstterraform apply
command and it doesn't get created until after the EKS cluster is completely setup causing the initial ENI create events to be missed.This PR ensures that the first
terraform apply
command:module.eventbridge
that takes care of creating both modulesmodule.create_eni_lambda
andmodule.delete_eni_lambda
module.delete_eni_lambda
onmodule.eks
How was this change tested?
pre-commit run -a
with this PR