POC for integration tests #1419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @BeforeAll | ||
| void setup() throws Exception { | ||
| if (LOCAL_CREDENTIALS != null && !LOCAL_CREDENTIALS.isEmpty()) { | ||
| System.out.println(LOCAL_CREDENTIALS); |
There was a problem hiding this comment.
Suggested change
| System.out.println(LOCAL_CREDENTIALS); | |
| System.out.println(LOCAL_CREDENTIALS); |
What credentials are these printing? Can we remove this if it was just for debugging?
There was a problem hiding this comment.
this is the path for the file containing the credentials. nonetheless, there is no reason for printing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a POC for running integration tests for the ADOT collector using a format similar to unit tests. The only limitation of this type of test is that we will not be able to run tests for platform specific components, such as awscontainerinsightsreciever and ecsobserver. All the other platform agnostic components can be potentially tested here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.