Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: impact of clear_state=True when using Lambda Layers & Logger #4458

Closed
1 task done
ChrisHills463 opened this issue Jun 6, 2024 · 5 comments · Fixed by #5956
Closed
1 task done

Docs: impact of clear_state=True when using Lambda Layers & Logger #4458

ChrisHills463 opened this issue Jun 6, 2024 · 5 comments · Fixed by #5956
Assignees
Labels
documentation Improvements or additions to documentation logger

Comments

@ChrisHills463
Copy link

What were you searching in the docs?

I was reading about Logger()

Is this related to an existing documentation section?

https://docs.powertools.aws.dev/lambda/python/latest/core/logger/#clearing-all-state

How can we improve?

The documentation contains a warning Danger: This can have unintended side effects if you use Layers however I believe this relates to using other layers as opposed to using the Powertools layer itself.

Got a suggestion in mind?

Something like...

Danger: This can have unintended side effects if you use Layers other than Powertools.

Acknowledgment

  • I understand the final update might be different from my proposed suggestion, or refused.
@ChrisHills463 ChrisHills463 added documentation Improvements or additions to documentation triage Pending triage from maintainers labels Jun 6, 2024
@sthulb
Copy link
Contributor

sthulb commented Jun 7, 2024

Hi @ChrisHills463,

The docs are correct, it affects us – we should probably change the wording though here with what it actually affects.

@heitorlessa heitorlessa self-assigned this Jun 24, 2024
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Jun 24, 2024
@heitorlessa heitorlessa moved this from Triage to Working on it in Powertools for AWS Lambda (Python) Jun 24, 2024
@heitorlessa
Copy link
Contributor

Assigning to release it this Thursday

@dreamorosi dreamorosi moved this from Working on it to Backlog in Powertools for AWS Lambda (Python) Oct 7, 2024
@leandrodamascena leandrodamascena self-assigned this Jan 24, 2025
@leandrodamascena leandrodamascena moved this from Backlog to Working on it in Powertools for AWS Lambda (Python) Jan 24, 2025
@dreamorosi
Copy link
Contributor

Hi @leandrodamascena, can you pick this up in the next iteration? Should be a quick one.

@dreamorosi dreamorosi changed the title Docs: Clarify warning around using clear_state=True with Logger() when using Powertools as a Lambda layer vs using other Lambda layers Docs: impact of clear_state=True when using Lambda Layers & Logger Jan 29, 2025
@leandrodamascena
Copy link
Contributor

Assigned to @anafalcao

@anafalcao anafalcao linked a pull request Jan 30, 2025 that will close this issue
7 tasks
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) Jan 31, 2025
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation logger
Projects
Status: Coming soon
Development

Successfully merging a pull request may close this issue.

6 participants