-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logger): add clear_state method #5956
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5956 +/- ##
========================================
Coverage 96.24% 96.24%
========================================
Files 234 234
Lines 11013 11016 +3
Branches 798 798
========================================
+ Hits 10599 10602 +3
Misses 327 327
Partials 87 87 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @anafalcao! SUPER NICE work!! 🥇
I left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anafalcao! We just need to fix one thing and we're ready to merge! Thanks for responding to all the comments.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @anafalcao! Just wait until CI is complete and you can merge!
APPROVED!
Issue number:
#4134
#4458
Summary
This PR introduces
clear_state()
method to the Logger class. This enhancement provides developers with more fine-grained control over the logger's state within a single Lambda function execution, allowing for more flexible and context-specific logging.Changes
clear_state()
method to the Logger classUser experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.