Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sui #92

Merged
merged 22 commits into from
Jul 12, 2024
Merged

Sui #92

merged 22 commits into from
Jul 12, 2024

Conversation

yinalaws
Copy link
Collaborator

@yinalaws yinalaws commented Jul 12, 2024

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

Motivation

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new node blueprints. Yes, I have added usage example to the README.md file in my blueprint folder
  • Mandatory for new node blueprints. Yes, I have implemented automated tests for all stacks in my blueprint and they pass
  • Mandatory for new node blueprints. Yes, I have added a reference to my README.md file to website/docs section for this feature
  • Yes, I have set up and ran all pre-merge quality control tools on my local machine and they don't show warnings.

For Moderators

  • The tests for all current blueprints successfully complete before merge?
  • Mandatory for new node blueprints. All pre-merge quality control tools and cdk-nag tools don't show warnings?
  • Mandatory for new node blueprints. The deployment test works on blank AWS account according to instructions in the README.md before merge?
  • Mandatory for new node blueprints. The website builds without errors?

Additional Notes

@evertonfraga evertonfraga self-requested a review July 12, 2024 15:39
@evertonfraga evertonfraga self-assigned this Jul 12, 2024
evertonfraga

This comment was marked as outdated.

Copy link
Contributor

@evertonfraga evertonfraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Approved.

I recommend doing a fast-follow addressing items on #93.

Great work, @yinalaws!

@evertonfraga evertonfraga merged commit f4112b9 into main Jul 12, 2024
1 check passed
@evertonfraga evertonfraga deleted the sui branch July 12, 2024 15:56
@evertonfraga
Copy link
Contributor

Closes #85.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants