-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uprev aws credentials github action and upgrade to use the latest blu… #137
Conversation
…eprints framework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@shapirov103 Blueprints upgrade is taken care, do we need this PR? |
This PR has been automatically marked as stale because it has been open 60 days |
@shapirov103 Is this PR needed anymore? |
@elamaran11 I must hhave prepared the PR and forgot to merge. The change in the github action seems to be relevant, the rest of the PR is stale. Let's keep it, I will review and resubmit after merging main. |
@elamaran11 please review when you get a chance, it is now in a mergeable state. If it works out here, you can take these changes to the CDK Observability repo as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…eprints framework
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.