Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uprev aws credentials github action and upgrade to use the latest blu… #137

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

shapirov103
Copy link
Contributor

…eprints framework

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

elamaran11
elamaran11 previously approved these changes Aug 24, 2023
Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11
Copy link
Contributor

@shapirov103 Blueprints upgrade is taken care, do we need this PR?

Copy link

This PR has been automatically marked as stale because it has been open 60 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@elamaran11
Copy link
Contributor

@shapirov103 Is this PR needed anymore?

@shapirov103
Copy link
Contributor Author

@elamaran11 I must hhave prepared the PR and forgot to merge. The change in the github action seems to be relevant, the rest of the PR is stale. Let's keep it, I will review and resubmit after merging main.

@shapirov103 shapirov103 requested a review from elamaran11 January 5, 2024 16:25
@shapirov103
Copy link
Contributor Author

@elamaran11 please review when you get a chance, it is now in a mergeable state. If it works out here, you can take these changes to the CDK Observability repo as well.

Copy link
Contributor

@elamaran11 elamaran11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elamaran11 elamaran11 merged commit 3aaf9af into main Jan 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants