Match framerate in DefaultVideoFrameProcessorPipeline with input stream #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensmi-amazon
approved these changes
Dec 30, 2024
| @@ -144,6 +144,7 @@ export default class DefaultVideoFrameProcessorPipeline implements VideoFramePro | |||
| this.inputVideoStream = inputMediaStream; | |||
| const settings = this.inputVideoStream.getVideoTracks()[0].getSettings(); | |||
| this.logger.info(`processing pipeline input stream settings ${JSON.stringify(settings)}`); | |||
| this.framerate = settings.frameRate; | |||
There was a problem hiding this comment.
This does have a 'surprise' performance impact to any customers with input > 15 FPS currently using the pipeline. But i think, at least with V2 bblur pipeline (assuming that is the main usage of this code) that the increase is reasonable, and this is a more 'expected' behavior.
ltrung
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Description of changes:
In
DefaultVideoFrameProcessorPipelinethe framerate is set as 15 fps. As a result, once video frame processor is applied, video framerate will be capped at 15 fps even if input fps is higher. This change matches this framerate with input video stream.Testing:
Smoke tested and verified video fps matches input stream after applying a video filter.
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Checklist:
Have you successfully run
npm run build:releaselocally?y
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
n
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
n
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.