Added code to save the managed instance's region to the stored cred profile #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. This feature ensures that Documents invoked on on-prem instances function the same as those invoked on EC2 instances.
…e. This feature ensures that Documents invoked on on-prem instances function the same as those invoked on EC2 instances.
…tial profile Scripts that use the .NET Cmdlets and aws command line tools will automatically detect the AWS Region from the EC2 instance profile, however, this is not the case for on-prem servers, since they don't have the EC2 Metadata service. By adding the Region to the shared credentials file, the SDK will be able to discover the region automatically. This will ensure that scripts that run on on-prem servers will run the same way as they would on EC2 instances, without any modification.
…have run, to ensure no pollution of later tests. Also altered the s3util so that if it fails to retrieve the instance region it returns an actual default value rather than an empty string, as well as logging the actual error message that occurred.
…n it returns an actual default value rather than an empty string
|
Hi thedevopsmachine, thank you for submitting the pull request. We're reviewing it. Please reply to comments for the code change. |
dimaAmz
suggested changes
Oct 29, 2018
| @@ -29,6 +29,7 @@ var ( | |||
| accessKeyID = "accessKeyID" | |||
| secretAccessKey = "secretAccessKey" | |||
| sessionToken = "sessionToken" | |||
| region = "us-east-1" | |||
| @@ -30,6 +30,7 @@ const ( | |||
| accessKey = "DummyAccessKey" | |||
| accessSecretKey = "DummyAccessSecretKey" | |||
| token = "DummyToken" | |||
| region = "us-east-1" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to save the managed instance's region to the stored credential profile
Scripts that use the .NET Cmdlets and aws command line tools will automatically detect the AWS Region from the EC2 instance profile, however, this is not the case for on-prem servers, since they don't have the EC2 Metadata service. By adding the Region to the shared credentials file, the SDK will be able to discover the region automatically. This will ensure that scripts that run on on-prem servers will run the same way as they would on EC2 instances, without any modification.