Skip to content

Commit

Permalink
rename OriginGroupSelectionCriteria to OriginSelectionCriteria to fit…
Browse files Browse the repository at this point in the history
… better with existing interfaces
  • Loading branch information
jamiepmullan committed Jan 5, 2025
1 parent e8f669a commit 6fb2474
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const originGroup = new origins.OriginGroup({
primaryOrigin: new origins.HttpOrigin(channelGroup.attrEgressDomain),
fallbackOrigin: new origins.HttpOrigin(channelGroup2.attrEgressDomain),
fallbackStatusCodes: [404],
selectionCriteria: cloudfront.OriginGroupSelectionCriteria.MEDIA_QUALITY_BASED,
selectionCriteria: cloudfront.OriginSelectionCriteria.MEDIA_QUALITY_BASED,
});

new cloudfront.Distribution(stack, 'Distribution', {
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-cloudfront-origins/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ new cloudfront.Distribution(this, 'myDist', {
primaryOrigin: new origins.HttpOrigin("<AWS Elemental MediaPackageV2 origin 1>"),
fallbackOrigin: new origins.HttpOrigin("<AWS Elemental MediaPackageV2 origin 2>"),
fallbackStatusCodes: [404],
selectionCriteria: cloudfront.OriginGroupSelectionCriteria.MEDIA_QUALITY_BASED,
selectionCriteria: cloudfront.OriginSelectionCriteria.MEDIA_QUALITY_BASED,
}),
},
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export interface OriginGroupProps {
*
* @default - nothing is returned
*/
readonly selectionCriteria?: cloudfront.OriginGroupSelectionCriteria;
readonly selectionCriteria?: cloudfront.OriginSelectionCriteria;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions packages/aws-cdk-lib/aws-cloudfront/lib/distribution.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { CfnDistribution, CfnMonitoringSubscription } from './cloudfront.generat
import { FunctionAssociation } from './function';
import { GeoRestriction } from './geo-restriction';
import { IKeyGroup } from './key-group';
import { IOrigin, OriginBindConfig, OriginBindOptions, OriginGroupSelectionCriteria } from './origin';
import { IOrigin, OriginBindConfig, OriginBindOptions, OriginSelectionCriteria } from './origin';
import { IOriginRequestPolicy } from './origin-request-policy';
import { CacheBehavior } from './private/cache-behavior';
import { formatDistributionArn } from './private/utils';
Expand Down Expand Up @@ -686,7 +686,7 @@ export class Distribution extends Resource implements IDistribution {
private addOriginGroup(originGroupId: string,
statusCodes: number[] | undefined,
originId: string, failoverOriginId: string,
selectionCriteria: OriginGroupSelectionCriteria | undefined): void {
selectionCriteria: OriginSelectionCriteria | undefined): void {
statusCodes = statusCodes ?? [500, 502, 503, 504];
if (statusCodes.length === 0) {
throw new Error('fallbackStatusCodes cannot be empty');
Expand Down
4 changes: 2 additions & 2 deletions packages/aws-cdk-lib/aws-cloudfront/lib/origin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Duration, Token } from '../../core';
*
* @default - none
*/
export enum OriginGroupSelectionCriteria {
export enum OriginSelectionCriteria {
/**
* Default selection behavior.
*/
Expand Down Expand Up @@ -55,7 +55,7 @@ export interface OriginBindConfig {
*
* @default - nothing is returned
*/
readonly selectionCriteria?: OriginGroupSelectionCriteria;
readonly selectionCriteria?: OriginSelectionCriteria;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ test('Selection criteria does set Media Quality Based failover', () => {
primaryOrigin: new origins.HttpOrigin(channelGroup.attrEgressDomain),
fallbackOrigin: new origins.HttpOrigin(channelGroup2.attrEgressDomain),
fallbackStatusCodes: [404],
selectionCriteria: cloudfront.OriginGroupSelectionCriteria.MEDIA_QUALITY_BASED,
selectionCriteria: cloudfront.OriginSelectionCriteria.MEDIA_QUALITY_BASED,
});

new cloudfront.Distribution(stack, 'dist', {
Expand Down

0 comments on commit 6fb2474

Please sign in to comment.