Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix deprecated parameters for actions-comment-pull-request #31805

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

atanaspam
Copy link
Contributor

@atanaspam atanaspam commented Oct 18, 2024

Reason for this change

The request-cli-integ-test pipeline is currently broken after a dependabot commit (af89640) which upgraded the version of the actions-comment-pull-request action to the latest changes which had breaking changes.

Description of changes

Updated the parameters passed to the action to correspond to the new naming convention as defined in the changelog.

Description of how you validated changes

I cannot test this myself, but the changes are straightforward.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 18, 2024 08:07
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 18, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@atanaspam
Copy link
Contributor Author

@kaizencc I think you ran into this issue too for workflows you approved.

@mrgrain mrgrain changed the title fix(ci): bad parameters for actions-comment-pull-request chore(ci): bad parameters for actions-comment-pull-request Oct 22, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 22, 2024 13:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 22, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 22, 2024
@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Oct 22, 2024
@mrgrain mrgrain changed the title chore(ci): bad parameters for actions-comment-pull-request chore(ci): fix deprecated parameters for actions-comment-pull-request Oct 22, 2024
@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Oct 22, 2024
@mrgrain
Copy link
Contributor

mrgrain commented Oct 22, 2024

Thank you!

Copy link
Contributor

mergify bot commented Oct 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8b2dc62
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit f656308 into aws:main Oct 22, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Oct 22, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants