Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use codecov token instead of OIDC #32129

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Nov 14, 2024

For PR from forks, OIDC doesn't currently work with the latest version of the GitHub Action.

Example failure:

Run codecov/codecov-action@v4
Error: Codecov: Failed to get OIDC token with url: https://codecov.io/. Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable

See codecov/codecov-action#1594

Revert back to token until we validate a fix.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 14, 2024 09:57
@github-actions github-actions bot added the p2 label Nov 14, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.14%. Comparing base (36d4d1a) to head (96616bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32129   +/-   ##
=======================================
  Coverage   77.14%   77.14%           
=======================================
  Files         105      105           
  Lines        7163     7163           
  Branches     1311     1311           
=======================================
  Hits         5526     5526           
  Misses       1457     1457           
  Partials      180      180           
Flag Coverage Δ
suite.unit 77.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.14% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 96616bd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Nov 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fb97684 into main Nov 14, 2024
32 checks passed
@mergify mergify bot deleted the epolon/codecov-use-token branch November 14, 2024 10:29
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants