-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): remove CDK_INTEG_MODE hack #32539
chore(cli): remove CDK_INTEG_MODE hack #32539
Conversation
This was never publicly advertised and is not used in our setup anymore. Remove to simplify toolkit code.
fc2c5b6
to
b1beae7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32539 +/- ##
==========================================
+ Coverage 78.77% 78.80% +0.03%
==========================================
Files 108 108
Lines 7163 7159 -4
Branches 1320 1319 -1
==========================================
- Hits 5643 5642 -1
+ Misses 1335 1332 -3
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
This hack was used to support the previous integration test system for the monorepo.
It was never publicly advertised and is not used in our setup anymore.
We are removing the unused code to simplify toolkit code.
Reason for this change
Cleaning up unused code.
Description of changes
Removed the unused code block.
Description of how you validated changes
Searched our repo and public GitHub for any usage. Only comes up in forks of the AWS CDK.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license