Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): remove CDK_INTEG_MODE hack #32539

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Dec 16, 2024

This hack was used to support the previous integration test system for the monorepo.
It was never publicly advertised and is not used in our setup anymore.
We are removing the unused code to simplify toolkit code.

Reason for this change

Cleaning up unused code.

Description of changes

Removed the unused code block.

Description of how you validated changes

Searched our repo and public GitHub for any usage. Only comes up in forks of the AWS CDK.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain requested a review from a team as a code owner December 16, 2024 13:47
@aws-cdk-automation aws-cdk-automation requested a review from a team December 16, 2024 13:47
@github-actions github-actions bot added the p2 label Dec 16, 2024
This was never publicly advertised and is not used in our setup anymore. Remove to simplify toolkit code.
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 16, 2024
@mrgrain mrgrain force-pushed the mrgrain/chore/remove-unsused-CDK_INTEG_MODE-hack branch from fc2c5b6 to b1beae7 Compare December 16, 2024 13:48
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 16, 2024
@aws-cdk-automation
Copy link
Collaborator

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.80%. Comparing base (a125c24) to head (02fa094).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32539      +/-   ##
==========================================
+ Coverage   78.77%   78.80%   +0.03%     
==========================================
  Files         108      108              
  Lines        7163     7159       -4     
  Branches     1320     1319       -1     
==========================================
- Hits         5643     5642       -1     
+ Misses       1335     1332       -3     
  Partials      185      185              
Flag Coverage Δ
suite.unit 78.80% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.80% <ø> (+0.03%) ⬆️

@mrgrain mrgrain added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Dec 16, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 16, 2024 15:49

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 16, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 02fa094
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e45fcae into main Dec 16, 2024
23 of 24 checks passed
@mergify mergify bot deleted the mrgrain/chore/remove-unsused-CDK_INTEG_MODE-hack branch December 16, 2024 16:19
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants