Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appsync): correct schema definition for Query type #32638

Closed
wants to merge 1 commit into from

Conversation

azarboon
Copy link
Contributor

@azarboon azarboon commented Dec 23, 2024

Issue # (if applicable)

Closes #.

Reason for this change

The current schema is incorrect and it fails stack deployment. I got the following error:
AppStack | 14.47.29 | CREATE_FAILED | AWS::AppSync::Resolver | Api/QueryGetDemosConsistentResolver (ApiQueryGetDemosConsistentResolver47D5A89B) Resource handler returned message: "No field named getDemosConsistent found on type Query (Service: AppSync, Status Code: 404, Request ID: 49d05d60-ec48-484f-a5ea-ce4e07424291)" (RequestToken: 1776599b-8208-1445-0cfc-01cfb2bde3b1, HandlerErrorCode: NotFound) ❌ AppStack failed: Error: The stack named AppStack failed creation, it may need to be manually deleted from the AWS console: ROLLBACK_COMPLETE: Resource handler returned message: "No field named getDemosConsistent found on type Query (Service: AppSync, Status Code: 404, Request ID: 49d05d60-ec48-484f-a5ea-ce4e07424291)" (RequestToken: 1776599b-8208-1445-0cfc-01cfb2bde3b1, HandlerErrorCode: NotFound)

Description of changes

I had to change the schema.graphql as following to fix the bug and enable deployment:

type Demo {
  id: String!
  version: String!
}

type Query {
  getDemos: [Demo!]
  getDemosConsistent: [Demo!]  
}

input DemoInput {
  version: String!
}

type Mutation {
  addDemo(input: DemoInput!): Demo
}

Describe any new or updated permissions being added

<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->

Description of how you validated changes

I locally tested it. Basically, the new update enabled me to deploy the example stack.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 23, 2024 08:29
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Dec 23, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@azarboon
Copy link
Contributor Author

Exemption Request

The code fails to deploy in its current state, preventing meaningful validation. Additionally, after reviewing the test files under the aws-appsync module, I couldn't find any tests specifically targeting schema.graphql. It appears schema validation isn't explicitly covered in the existing test suite.

Could you please consider exempting this change from mandatory test coverage, or guide me to any relevant test files if they do exist?

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Dec 23, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: b9fb7bc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 23, 2024
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@azarboon azarboon closed this Dec 24, 2024
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants