Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli-integ): remove in-source compilation of 'bin' directory #32642

Merged
merged 3 commits into from
Dec 23, 2024
Merged

chore(cli-integ): remove in-source compilation of 'bin' directory #32642

merged 3 commits into from
Dec 23, 2024

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Dec 23, 2024

The CLI integ test package relies on the bin directory being compiled in-source. In new projen-managed setups, this is not common anymore.

Move the actual CLI sources into the lib/cli directory and launch them from there.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
chore: remove in-source compilation of 'bin' directory
a90e12d 
The CLI integ test package relies on the `bin` directory being compiled
in-source. In new projen-managed setups, this is not common anymore.

Remove the dependency.
@rix0rrr rix0rrr requested a review from a team as a code owner December 23, 2024 11:32
@github-actions github-actions bot added the p2 label Dec 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 23, 2024 11:32
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 23, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (5aec766) to head (4111749).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32642   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files         106      106           
  Lines        6954     6954           
  Branches     1287     1287           
=======================================
  Hits         5601     5601           
  Misses       1175     1175           
  Partials      178      178
Flag Coverage Δ
suite.unit 80.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.54% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 23, 2024
iliapolo
iliapolo reviewed Dec 23, 2024
View reviewed changes
packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md Outdated
@@ -93,71 +93,7 @@ The following json shows the current recommended set of flags, as `cdk init` wou

<!-- BEGIN json -->
```json
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem related to the PR? is this intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 23, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4111749
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ff21117 into main Dec 23, 2024
16 of 17 checks passed
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the huijbers/integ-tests branch December 23, 2024 15:28
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rix0rrr @aws-cdk-automation @iliapolo