Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): turn cliArguments into camelCase #32697

Merged
merged 2 commits into from
Dec 31, 2024
Merged

chore(cli): turn cliArguments into camelCase #32697

merged 2 commits into from
Dec 31, 2024

Conversation

kaizencc
Copy link
Contributor

This just standardizes the style more similarly to the rest of aws-cdk

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc requested a review from a team as a code owner December 31, 2024 15:53
@github-actions github-actions bot added the p2 label Dec 31, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 31, 2024 15:53
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 31, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 31, 2024
@kaizencc kaizencc changed the title chore(cli): turn cliArguments into camelcase chore(cli): turn cliArguments into camelCase Dec 31, 2024
@kaizencc kaizencc added pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Dec 31, 2024
@kaizencc
Copy link
Contributor Author

This cannot affect cli integ tests

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 31, 2024 15:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.95%. Comparing base (6c790fd) to head (e30ed04).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32697   +/-   ##
=======================================
  Coverage   66.95%   66.95%           
=======================================
  Files         329      329           
  Lines       18662    18662           
  Branches     3257     3257           
=======================================
  Hits        12496    12496           
  Misses       5839     5839           
  Partials      327      327           
Flag Coverage Δ
suite.unit 66.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.71% <ø> (ø)
packages/aws-cdk-lib/core 82.08% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e30ed04
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Dec 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 56ed0e5 into main Dec 31, 2024
19 of 20 checks passed
@mergify mergify bot deleted the conroy/camelcase branch December 31, 2024 16:37
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants