Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update L1 CloudFormation resource definitions #32712

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

aws-cdk-automation
Copy link
Collaborator

Updates the L1 CloudFormation resource definitions with the latest changes from @aws-cdk/aws-service-spec

L1 CloudFormation resource definition changes:

├[~] service aws-dms
│ └ resources
│    └[~]  resource AWS::DMS::DataProvider
│       └ types
│          ├[+]  type DocDbSettings
│          │  ├      documentation: DocDbSettings property identifier.
│          │  │      name: DocDbSettings
│          │  └ properties
│          │     ├ ServerName: string (required)
│          │     ├ Port: integer (required)
│          │     ├ DatabaseName: string (required)
│          │     ├ SslMode: string
│          │     └ CertificateArn: string
│          ├[+]  type MariaDbSettings
│          │  ├      documentation: MariaDbSettings property identifier.
│          │  │      name: MariaDbSettings
│          │  └ properties
│          │     ├ ServerName: string (required)
│          │     ├ Port: integer (required)
│          │     ├ SslMode: string (required)
│          │     └ CertificateArn: string
│          ├[+]  type MongoDbSettings
│          │  ├      documentation: MongoDbSettings property identifier.
│          │  │      name: MongoDbSettings
│          │  └ properties
│          │     ├ ServerName: string (required)
│          │     ├ Port: integer (required)
│          │     ├ DatabaseName: string
│          │     ├ SslMode: string
│          │     ├ CertificateArn: string
│          │     ├ AuthType: string
│          │     ├ AuthSource: string
│          │     └ AuthMechanism: string
│          ├[+]  type RedshiftSettings
│          │  ├      documentation: RedshiftSettings property identifier.
│          │  │      name: RedshiftSettings
│          │  └ properties
│          │     ├ ServerName: string (required)
│          │     ├ Port: integer (required)
│          │     └ DatabaseName: string (required)
│          └[~] type Settings
│            └ properties
│               ├[+] DocDbSettings: DocDbSettings
│               ├[+] MariaDbSettings: MariaDbSettings
│               ├[+] MongoDbSettings: MongoDbSettings
│               └[+] RedshiftSettings: RedshiftSettings
├[~] service aws-dynamodb
│ └ resources
│    ├[~]  resource AWS::DynamoDB::GlobalTable
│    │  └ properties
│    │     └[+] PointInTimeRecoverySpecification: PointInTimeRecoverySpecification
│    └[~]  resource AWS::DynamoDB::Table
│       └ types
│          └[~] type PointInTimeRecoverySpecification
│            └ properties
│               └[+] RecoveryPeriodInDays: integer
├[~] service aws-iot
│ └ resources
│    └[~]  resource AWS::IoT::DomainConfiguration
│       └ types
│          └[~] type ServerCertificateConfig
│            └ properties
│               ├ OcspAuthorizedResponderArn: (documentation changed)
│               └ OcspLambdaArn: (documentation changed)
├[~] service aws-qbusiness
│ └ resources
│    └[~]  resource AWS::QBusiness::DataAccessor
│       └ properties
│          └ ApplicationId: - string (immutable)
│                           + string (required, immutable)
├[~] service aws-quicksight
│ └ resources
│    ├[~]  resource AWS::QuickSight::DataSet
│    │  └ types
│    │     └[~] type UploadSettings
│    │       ├      - documentation: Information about the format for a source file or files.
│    │       │      + documentation: undefined
│    │       └ properties
│    │          ├ ContainsHeader: (documentation changed)
│    │          ├ Delimiter: (documentation changed)
│    │          ├ Format: (documentation changed)
│    │          ├ StartFromRow: (documentation changed)
│    │          └ TextQualifier: (documentation changed)
│    └[~]  resource AWS::QuickSight::Template
│       └ types
│          └[~] type SheetImageTooltipConfiguration
│            └ properties
│               └ Visibility: - json ⇐ string
│                             + json
├[~] service aws-s3
│ └ resources
│    └[~]  resource AWS::S3::Bucket
│       └ types
│          └[~] type TagFilter
│            └      - documentation: Specifies tags to use to identify a subset of objects for an Amazon S3 bucket.
│                   + documentation: Specifies tags to use to identify a subset of objects for an Amazon S3 bucket. For more information, see [Categorizing your storage using tags](https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-tagging.html) in the *Amazon Simple Storage Service User Guide* .
└[~] service aws-wafv2
  └ resources
     ├[~]  resource AWS::WAFv2::RuleGroup
     │  └ types
     │     └[~] type Rule
     │       └ properties
     │          └ RuleLabels: (documentation changed)
     └[~]  resource AWS::WAFv2::WebACL
        └ types
           └[~] type Rule
             └ properties
                └ RuleLabels: (documentation changed)

Updates the L1 CloudFormation resource definitions with the latest changes from `@aws-cdk/aws-service-spec`
@aws-cdk-automation aws-cdk-automation added auto-approve contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jan 2, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 2, 2025 19:20
@github-actions github-actions bot added the p2 label Jan 2, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 2, 2025 19:20
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.96%. Comparing base (721e700) to head (3f27e9c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32712   +/-   ##
=======================================
  Coverage   66.96%   66.96%           
=======================================
  Files         329      329           
  Lines       18663    18663           
  Branches     3258     3258           
=======================================
  Hits        12497    12497           
  Misses       5839     5839           
  Partials      327      327           
Flag Coverage Δ
suite.unit 66.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.71% <ø> (ø)
packages/aws-cdk-lib/core 82.08% <ø> (ø)

Copy link
Contributor

mergify bot commented Jan 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 3170e1c into main Jan 2, 2025
17 of 19 checks passed
@mergify mergify bot deleted the automation/spec-update branch January 2, 2025 20:21
@aws-cdk-automation
Copy link
Collaborator Author

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3f27e9c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 2, 2025

This pull request has been removed from the queue for the following reason: pull request unexpectedly failed to merge.

Pull request unexpectedly failed to get merged

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link
Contributor

mergify bot commented Jan 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

github-actions bot commented Jan 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-approve contribution/core This is a PR that came from AWS. dependencies This issue is a problem in a dependency or a pull request that updates a dependency file. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant