Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli-integ): migrate tests can fail because they don't bootstrap #32714

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jan 2, 2025

CDK Migrate tests rely on other tests having bootstrapped their target regions already. That fails if they run first.

Add bootstrapping commands to these tests as well.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…trap

CDK Migrate tests rely on other tests having bootstrapped their
target regions already. That fails if they run first.

Add bootstrapping commands to these tests as well.
@rix0rrr rix0rrr requested a review from a team as a code owner January 2, 2025 19:55
@github-actions github-actions bot added the p2 label Jan 2, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 2, 2025 19:55
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 2, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@rix0rrr rix0rrr changed the title chore(cli-integ): CDK migrate tests can fail because they don't bootstrap chore(cli-integ): migrate tests can fail because they don't bootstrap Jan 2, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 2, 2025 20:17

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Jan 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.96%. Comparing base (3170e1c) to head (f54f2d0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32714   +/-   ##
=======================================
  Coverage   66.96%   66.96%           
=======================================
  Files         329      329           
  Lines       18663    18663           
  Branches     3258     3258           
=======================================
  Hits        12497    12497           
  Misses       5839     5839           
  Partials      327      327           
Flag Coverage Δ
suite.unit 66.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.71% <ø> (ø)
packages/aws-cdk-lib/core 82.08% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f54f2d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jan 2, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 364ce86 into main Jan 2, 2025
18 of 20 checks passed
@mergify mergify bot deleted the huijbers/tests-ensure-bootstrapped branch January 2, 2025 21:04
Copy link
Contributor

mergify bot commented Jan 2, 2025

This pull request has been removed from the queue for the following reason: pull request unexpectedly failed to merge.

Pull request unexpectedly failed to get merged

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

Copy link

github-actions bot commented Jan 2, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants